Fix #3953: Patch the types of ParamDefs to match their method signature. #4533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the cases that produce no `js.MethodDef` at all are now handled directly in `genMethod`. This allows `genMethodWithCurrentLocalNameScope` to return a `js.MethodDef` instead of an `Option[js.MethodDef]`. In addition, we compute `jsParams` only once, with the same code for all cases.
gzm0
approved these changes
Jul 15, 2021
… signature. In some rare cases that involve Higher Kinded Types and type aliases, scalac produces DefDef's whose params' types do not match the method type. This is filed upstream as scala/bug#11884 We work around the issue by patching a posteriori the types of `js.ParamDef`s and their `js.VarRef`s to match the type advertised by the method type. In the entire test suite, the only method that requires a patch is the `PartialFunction`'s `applyOrElse` in the newly added test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare cases that involve Higher Kinded Types and type aliases, scalac produces DefDef's whose params' types do not match the method type. This is filed upstream as scala/bug#11884
We work around the issue by patching a posteriori the types of
js.ParamDefs and theirjs.VarRefs to match the type advertised by the method type.In the entire test suite, the only method that requires a patch is the
PartialFunction'sapplyOrElsein the newly added test case.