8000 Replace topoSortDistinctsBy with topoSortDistinctsWith by gzm0 · Pull Request #4462 · scala-js/scala-js · GitHub
[go: up one dir, main page]
Skip to content

Replace topoSortDistinctsBy with topoSortDistinctsWith #4462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000
Merged
merged 1 commit into from
Apr 6, 2021
Merged

Replace topoSortDistinctsBy with topoSortDistinctsWith #4462

merged 1 commit into from
Apr 6, 2021

Conversation

gzm0
Copy link
Contributor
@gzm0 gzm0 commented Apr 5, 2021

No description provided.

@gzm0 gzm0 requested a review from sjrd April 5, 2021 19:39
@gzm0
Copy link
Contributor Author
gzm0 commented Apr 5, 2021

Found while working on #4442. Seems simpler this way.

@gzm0 gzm0 merged commit 143aabe into scala-js:master Apr 6, 2021
@gzm0 gzm0 deleted the simpler-topo-sort branch April 6, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gzm0 @sjrd
0