Fix #4098: Avoid let/const when building the ASTs for GCC.
#4110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now use `var`s instead, which do not expose the issue. This is a workaround for an unknown root cause. We should properly fix this in the future.
gzm0
approved these changes
Jul 1, 2020
| val set = new java.util.HashSet[String]() | ||
| set.remove("") | ||
| set.remove("1") // only if remove is called twice | ||
| assertEquals(0, set.size()) |
There was a problem hiding this comment.
Does this fail in the test suite without the fix? (i.e. does it fail not in isolation?).
There was a problem hiding this comment.
Yes, it does. I had checked ;)
|
Just tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use
vars instead, which do not expose the issue.This is a workaround for an unknown root cause. We should properly fix this in the future.