8000 Also run test-common tests in JS by gzm0 · Pull Request #3700 · scala-js/scala-js · GitHub
[go: up one dir, main page]
Skip to content

Also run test-common tests in JS #3700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2019
Merged

Also run test-common tests in JS #3700

merged 3 commits into from
Jun 18, 2019

Conversation

gzm0
Copy link
Contributor
@gzm0 gzm0 commented Jun 16, 2019

This is possible since we now have async support for JUnit.

@gzm0 gzm0 requested a review from sjrd June 16, 2019 16:25
sjrd
sjrd requested changes Jun 17, 2019
View reviewed changes
Copy link
Member
@sjrd sjrd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit "Also run test-common tests in JS" should add testBridge/test somewhere in Jenkinsfile, otherwise the new tests won't be executed on the CI.

Otherwise LGTM.

@gzm0 gzm0 force-pushed the test-common-js-test branch from 5af6cb5 to dade03e Compare June 17, 2019 11:43
@gzm0
Copy link
Contributor Author
gzm0 commented Jun 17, 2019

Added it to "bootstrap" not the nicest but also not the worst...

@sjrd
Copy link
Member
sjrd commented Jun 17, 2019 •
edited
Loading

Did you consider putting it next to jUnitTestOutputsJS/test? They seem to be more or less part of the same "category" of projects (supporting test infrastructure on the JS side).

(bootstrap is not run on all versions, for example it's not run on 2.13 at the moment)

gzm0 added 3 commits June 18, 2019 12:55
@gzm0
Remove unnecessary fail helpers
23ea680 
They were most likely introduced to work around the lack of a
`Nothing` type in Java. `fail` seems not to be used in expression
position anymore, so we can use the one provided by JUnit directly.
@gzm0
Always write : AsyncResult = await { for async tests
aec0426 
- Removes clutter from test body.
- Easy to check that await is called.
@gzm0
Also run test-common tests in JS
a9efb42 
This is possible since we now have async support for JUnit.
@gzm0 gzm0 force-pushed the test-common-js-test branch from dade03e to a9efb42 Compare June 18, 2019 11:03
@gzm0
Copy link
Contributor Author
gzm0 commented Jun 18, 2019

Rebased and updated.

@sjrd sjrd merged commit 2e2e2bc into scala-js:master Jun 18, 2019
@gzm0 gzm0 deleted the test-common-js-test branch July 2, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gzm0 @sjrd
0