-
Notifications
You must be signed in to change notification settings - Fork 396
Fix #1526: Implement java.lang.Thread.{get,set}Name. #1528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
expect(t.getName).toBe("main") // default name of the main thread | ||
t.setName("foo") | ||
expect(t.getName).toBe("foo") | ||
t.setName("main") // don't pollute the rest of the world with this test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a finally block, in case the expect
above fails?
Test FAILed. https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1468/ |
Updated with the try-finally. |
Test FAILed. https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1469/ |
retest this please |
LGTM |
Test FAILed. https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1470/ |
Rebuilding one failed task: https://scala-webapps.epfl.ch/jenkins/job/scalajs-task-worker/31462/ |
Rebuild passed. |
Fix #1526: Implement java.lang.Thread.{get,set}Name.
No description provided.