8000 Fix #1526: Implement java.lang.Thread.{get,set}Name. by sjrd · Pull Request #1528 · scala-js/scala-js · GitHub
[go: up one dir, main page]

Skip to content

Fix #1526: Implement java.lang.Thread.{get,set}Name. #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2015

Conversation

sjrd
Copy link
Member
@sjrd sjrd commented Mar 11, 2015

No description provided.

expect(t.getName).toBe("main") // default name of the main thread
t.setName("foo")
expect(t.getName).toBe("foo")
t.setName("main") // don't pollute the rest of the world with this test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a finally block, in case the expect above fails?

@scala-jenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):

https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1468/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/1894/
Test FAILed.

@sjrd
Copy link
Member Author
sjrd commented Mar 12, 2015

Updated with the try-finally.

@scala-jenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):

https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1469/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/1896/
Test FAILed.

@sjrd
Copy link
Member Author
sjrd commented Mar 12, 2015

retest this please

@gzm0
Copy link
Contributor
gzm0 commented Mar 12, 2015

LGTM

@scala-jenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):

https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1470/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/1897/
Test FAILed.

@sjrd
Copy link
Member Author
sjrd commented Mar 12, 2015

@sjrd
Copy link
Member Author
sjrd commented Mar 13, 2015

Rebuild passed.

sjrd added a commit that referenced this pull request Mar 13, 2015
Fix #1526: Implement java.lang.Thread.{get,set}Name.
@sjrd sjrd merged commit 48e96cc into scala-js:master Mar 13, 2015
@sjrd sjrd deleted the thread-name branch March 13, 2015 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
44FA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0