8000 Rewire mutable.Buffer.newBuilder to js.WrappedArray · Issue #1120 · scala-js/scala-js · GitHub
[go: up one dir, main page]
Skip to content

Rewire mutable.Buffer.newBuilder to js.WrappedArray #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sjrd opened this issue Sep 26, 2014 · 1 comment
Closed

Rewire mutable.Buffer.newBuilder to js.WrappedArray #1120

sjrd opened this issue Sep 26, 2014 · 1 comment
Assignees
@sjrd
Labels
enhancement Feature request (that does not concern language semantics, see "language")
Milestone
v0.6.0-M1

Comments

@sjrd
Copy link
Member
sjrd commented Sep 26, 2014

See #1119.
@sjrd sjrd added the enhancement Feature request (that does not concern language semantics, see "language") label Sep 26, 2014
@sjrd sjrd self-assigned this Sep 26, 2014
@sjrd sjrd added this to the v0.6.0 milestone Sep 26, 2014
@sjrd
Copy link
Member Author
sjrd commented Sep 26, 2014

And in the process, make js.WrappedArray inherit from AbstractBuffer instead of AbstractSeq. I missed that opportunity for "optimization" when I wrote #1119.

@sjrd sjrd added the has-pr label Oct 1, 2014
@sjrd sjrd closed this as completed in 757949e Oct 3, 2014
gzm0 added a commit that referenced this issue Oct 3, 2014
@gzm0
Merge pull request #1128 from sjrd/js-wrappedarray-default-buffer
a0456c4 
Fix #1120: Rewire mutable.Buffer.newBuilder to js.WrappedArray.
@sjrd sjrd removed the has-pr label Jul 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjrd sjrd

Labels
enhancement Feature request (that does not concern language semantics, see "language")
Projects
None yet
Milestone
v0.6.0-M1
Development

No branches or pull requests
1 participant
@sjrd
0