Enable Scala 3 migration mode #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeal18
commented
Jul 25, 2024
| final case class HyperEdge[+N] private (override val ends: Several[N]) | ||
| final case class HyperEdge[+N](override val ends: Several[N]) |
There was a problem hiding this comment.
it's not private any more because of the synthesised copy method, which doesn't follow the constructor encapsulation in Scala 2, but follows in Scala 3 and it breaks compatibility
more details: https://docs.scala-lang.org/scala3/guides/migration/tooling-scala2-xsource3.html#changes-in-language-semantics
7cfc5d6 to
c27e873
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was suggested in another PR (#323) I'm enabling the compiler migration mode first