8000 Support -d with .jar paths by nicolasstucki · Pull Request #3382 · scala/scala3 · GitHub
[go: up one dir, main page]
Skip to content

Support -d with .jar paths #3382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 16, 2017
Merged

Support -d with .jar paths #3382

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
507f8d7
Support -d with .jar paths
nicolasstucki Oct 25, 2017
8c5bc9e
Use java.nio.file.FileSystems to write to jar directly
nicolasstucki Oct 26, 2017
93b1214
Further improve dotty.io
allanrenucci Nov 14, 2017
ee7a8f1
Move JarOutputTests to SettingsTests
allanrenucci Nov 15, 2017
4e39251
Make outputDir a PathSetting
allanrenucci Nov 15, 2017
4a0606a
Don't catch exceptions when closing jar
allanrenucci Nov 15, 2017
2e79154
Add JarArchive as a new kind of output directory
allanrenucci Nov 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't catch exceptions when closing jar
  • Loading branch information
@allanrenucci
allanrenucci committed Nov 15, 2017
commit 4a0606a68783b32b061e1fa96f6930cf7f1131b2
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/backend/jvm/GenBCode.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ class GenBCode extends Phase {
override def runOn(units: List[CompilationUnit])(implicit ctx: Context) = {
try super.runOn(units)
finally if (jarFS ne null) {
try { jarFS.close() } catch { case _: Throwable => }
jarFS.close()
jarFS = null
}
}
Expand Down
0