8000 fix: hover and go to definition for named tuples by kasiaMarek · Pull Request #22202 · scala/scala3 · GitHub
[go: up one dir, main page]
Skip to content

fix: hover and go to definition for named tuples #22202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2025
Merged

fix: hover and go to definition for named tuples #22202

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c8b63d
fix: hover and go to definition for named tuples
kasiaMarek Dec 12, 2024
36d214e
dealias type in selectable
kasiaMarek Dec 13, 2024
a6810d4
move `named tuples` case lower
kasiaMarek Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
dealias type in selectable
  • Loading branch information
@kasiaMarek
kasiaMarek committed Jan 13, 2025
commit 36d214eddfac1823d24b29c9afbe6c01f73b5057
3 changes: 2 additions & 1 deletion presentation-compiler/src/main/dotty/tools/pc/HoverProvider.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,8 @@ object HoverProvider:
case RefinedType(_, refName, tpe) if (name == refName.toString() || refName.toString() == nme.Fields.toString()) =>
val resultType =
rest match
case Select(_, asInstanceOf) :: TypeApply(_, List(tpe)) :: _ if asInstanceOf == nme.asInstanceOfPM => tpe.tpe
case Select(_, asInstanceOf) :: TypeApply(_, List(tpe)) :: _ if asInstanceOf == nme.asInstanceOfPM =>
tpe.tpe.widenTermRefExpr.deepDealias
case _ if n == nme.selectDynamic => tpe.resultType
case _ => tpe

Expand Down
0