8000 overhaul of mailing lists section by SethTisue · Pull Request #329 · scala/scala-lang · GitHub
[go: up one dir, main page]
Skip to content

overhaul of mailing lists section #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
heathermiller merged 1 commit into from
Sep 14, 2015
Merged

overhaul of mailing lists section #329

heathermiller merged 1 commit into from
Sep 14, 2015

Conversation

@SethTisue
Copy link
Member
@SethTisue SethTisue commented Sep 14, 2015
  • put them in a better order
  • revised wording for list descriptions, including incorporating the
    best bits of the mailing list descriptions that were removed from
    the Code of Conduct page by
    minor tweaks to code of conduct page docs.scala-lang#455
  • add the no-job-listings blurb from the CoC page, removed
    by the same PR
  • don't list scala-xml anymore, it's pretty dead
  • move the Gmane links to the end, for a less cluttered look

review by @heathermiller, @dickwall, @jsuereth

@SethTisue
overhaul of mailing lists section
ca63666 
- put them in a better order
- revised wording for list descriptions, including incorporating the
  best bits of the mailing list descriptions that were removed from
  the Code of Conduct page by
  scala/docs.scala-lang#455
- add the no-job-listings blurb from the CoC page, removed
  by the same PR
- don't list scala-xml anymore, it's pretty dead
- move the Gmane links to the end, for a less cluttered look
@SethTisue SethTisue mentioned this pull request Sep 14, 2015
Merged
@heathermiller
Copy link
Member
heathermiller commented Sep 14, 2015

Great! LGTM!
One small question though, did you try generating it? If I recall correctly, sometimes linebreaks between bullet points end up being translated to new <p> blocks, which can look a bit odd. Up to you though, just asking.

@SethTisue
Copy link
Member Author
SethTisue commented Sep 14, 2015

I double-checked just now and it seems fine.

@heathermiller
Copy link
Member
heathermiller commented Sep 14, 2015

LGTM then! @dickwall and/or @jsuereth, if you guys have anything you'd like to add or change, please comment here or make a separate PR.

Thanks Seth!

heathermiller added a commit that referenced this pull request Sep 14, 2015
@heathermiller
Merge pull request #329 from SethTisue/mailing-list-revisions
fde6d73 
overhaul of mailing lists section
@heathermiller heathermiller merged commit fde6d73 into scala:master Sep 14, 2015
@SethTisue SethTisue deleted the mailing-list-revisions branch September 14, 2015 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SethTisue @heathermiller
0