8000 Travis-CI: add JDK 17 (replacing JDK 16) by SethTisue · Pull Request #9677 · scala/scala · GitHub
[go: up one dir, main page]
Skip to content

Travis-CI: add JDK 17 (replacing JDK 16) #9677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 27, 2021
Merged

Travis-CI: add JDK 17 (replacing JDK 16) #9677

merged 5 commits into from
Jul 27, 2021

Conversation

SethTisue
Copy link
Member

No description provided.

@scala-jenkins scala-jenkins added this to the 2.13.7 milestone Jun 23, 2021
@SethTisue SethTisue added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Jun 23, 2021
@SethTisue
Copy link
Member Author

CI isn't testing this, because the JDK 16/17 job runs mergely.

I'll add a commit, not for merge, that adds it to PR validation.

@SethTisue
Copy link
Member Author

https://github.com/scala/scala-dev/blob/scala-dev/travis/default.yml is looking for AdoptOpenJDK only (hs-adpt), but here we want a Java.net build.

@SethTisue SethTisue marked this pull request as draft June 24, 2021 00:25
@SethTisue
Copy link
Member Author

we want a Java.net build

fixed by scala/scala-dev#780

@SethTisue
Copy link
Member Author 
[error] /home/travis/build/scala/scala/src/partest/scala/tools/partest/SecurityTest.scala:19:35: class AccessControlExce
ption in package security is deprecated
[error]   def throwIt(x: Any) = throw new AccessControlException("" + x)
[error]                                   ^
[error] /home/travis/build/scala/scala/src/partest/scala/tools/partest/nest/DelegatingSecurityManager.scala:19:68: class
 SecurityManager in package lang is deprecated
[error] class DelegatingSecurityManager(delegate: SecurityManager) extends SecurityManager {
[error]                                                                    ^
[error] /home/travis/build/scala/scala/src/partest/scala/tools/partest/nest/DelegatingSecurityManager.scala:19:43: class
 SecurityManager in package lang is deprecated
[error] class DelegatingSecurityManager(delegate: SecurityManager) extends SecurityManager {
[error]                                           ^
[error] /home/travis/build/scala/scala/src/partest/scala/tools/partest/nest/TrapExit.scala:23:24: method getSecurityMana
ger in class System is deprecated
[error]     val saved = System.getSecurityManager
[error]                        ^
[error] /home/travis/build/scala/scala/src/partest/scala/tools/partest/nest/TrapExit.scala:24:12: method setSecurityManager in class System is deprecated
[error]     System.setSecurityManager(new DelegatingSecurityManager(saved) {
[error]            ^
[error] /home/travis/build/scala/scala/src/partest/scala/tools/partest/nest/TrapExit.scala:33:14: method setSecurityManager in class System is deprecated
[error]       System.setSecurityManager(saved)
[error]              ^
[error] 6 errors found

@SethTisue SethTisue force-pushed the jdk17 branch 3 times, most recently from 21072d8 to eec304c Compare July 16, 2021 21:59
@SethTisue SethTisue marked this pull request as ready for review July 23, 2021 00:27
@SethTisue
Copy link
Member Author

hey it's green! removing the "NOT FOR MERGE temporarily run jdk 17 cron in PR validation" commit now

@SethTisue SethTisue requested a review from lrytz July 23, 2021 00:29
dwijnand
dwijnand approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member
@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work

@SethTisue SethTisue merged commit 4ede583 into scala:2.13.x Jul 27, 2021
@SethTisue SethTisue deleted the jdk17 branch July 27, 2021 21:00
This was referenced Sep 29, 2021
Closed
Merged
SethTisue added a commit to SethTisue/scala that referenced this pull request Sep 29, 2021
@SethTisue
fix t2318 on JDK 17
fbb7794 
backports one piece of scala#9677

fixes scala/scala-dev#790
hamzaremmal pushed a commit to hamzaremmal/scala3 that referenced this pull request May 2, 2025
@SethTisue
Merge pull request scala/scala#9677 from SethTisue/jdk17
cc0bbed
hamzaremmal pushed a commit to scala/scala3 that referenced this pull request May 7, 2025
@SethTisue
Merge pull request scala/scala#9677 from SethTisue/jdk17
69161c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

@lrytz lrytz Awaiting requested review from lrytz

Assignees
No one assigned
Labels
internal not resulting in user-visible changes (build changes, tests, internal cleanups)
Projects
None yet
Milestone
2.13.7
Development

Successfully merging this pull request may close these issues.
3 participants
@SethTisue @dwijnand @scala-jenkins
0