Retain var class param if used #9005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally a `private[this]` class parameter does not get a field if it is not referenced outside the constructor. For a var, also check that it is not assigned to inside the constructor.
dwijnand
approved these changes
Jun 2, 2020
There was a problem hiding this comment.
No expert, but LGTM.
I mean: adding traversals is expensive, right? So, ideally, it would be nice to define this separately and fuse it with the detectUsages traversal. But if there's no clean/easy/nice way to do that, to me this looks like it does a nice job minimising additional work.
|
Agreed this is a baby step for correctness. The phase does quite some work in a couple of passes. I mention somewhere that I wanted to move the var in this case to the constructor, but didn't have time to spend. The class has grown over time and seen a previous refactor; it's probably time again. Not sure if I mentioned somewhere that doti does not elide fields at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally a
private[this]class parameter does not geta field if it is not referenced outside the constructor.
For a var, also check that it is not assigned to inside
the constructor.
Fixes scala/bug#12002