8000 Add AdoptOpenJDK JDK 11 to the PR validation by eed3si9n · Pull Request #8207 · scala/scala · GitHub
[go: up one dir, main page]
Skip to content

Add AdoptOpenJDK JDK 11 to the PR validation #8207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from 8000
Closed

Add AdoptOpenJDK JDK 11 to the PR validation #8207

wants to merge 4 commits into from

Conversation

eed3si9n
Copy link
Member
@eed3si9n eed3si9n commented Jul 8, 2019

This is a continuation of #7931 to check AdoptOpenJDK JDK 11.

@scala-jenkins scala-jenkins added this to the 2.13.1 milestone Jul 8, 2019
@eed3si9n
Copy link
Member Author
eed3si9n commented Jul 8, 2019

https://travis-ci.org/scala/scala/jobs/555853152

[error]  
[error] 3 of 17 test tasks failed:
[error] - partest run
[error]   - test/it:testOnly failed: sbt.TestsFailedException: Tests unsuccessful
[error] - partest pos neg jvm
[error]   - test/it:testOnly failed: sbt.TestsFailedException: Tests unsuccessful
[error] - library/mimaReportBinaryIssues
[error]   - library/mimaReportBinaryIssues failed: java.lang.RuntimeException: scala-library: Binary compatibility check failed!
[error] Saved log of library/mimaReportBinaryIssues:
[error]  * method asIterator()java.util.Iterator in class scala.collection.convert.JavaCollectionWrappers#IteratorWrapper does not have a correspondent in other version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("scala.collection.convert.JavaCollectionWrappers#IteratorWrapper.asIterator")
[error] testAll failed due to previous errors

@dwijnand dwijnand added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Jul 9, 2019
@dwijnand dwijnand mentioned this pull request Jul 9, 2019
Closed
@eed3si9n eed3si9n mentioned this pull request Jul 9, 2019
Closed
@eed3si9n
Add AdoptOpenJDK JDK 11 to the PR validation
54f211c 
Ref scala/scala-dev#587

This is a continuation of scala#7931 to check AdoptOpenJDK JDK 11.
@eed3si9n eed3si9n changed the base branch from 2.13.x to 2.12.x July 10, 2019 22:04
@eed3si9n eed3si9n closed this Jul 10, 2019
@eed3si9n eed3si9n reopened this Jul 10, 2019
@eed3si9n eed3si9n modified the milestones: 2.13.1, 2.12.9 Jul 11, 2019
@lrytz
Copy link
Member
lrytz commented Jul 12, 2019

I think we can move this one to 2.13.x for now, and consider back-porting later. But we have to merge the travis changes to 2.13.x first.

There are quite a few tests to fix, starting by backporting #6889.

@lrytz lrytz closed this Jul 12, 2019
@SethTisue SethTisue removed this from the 2.12.9 milestone Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal not resulting in user-visible changes (build changes, tests, internal cleanups)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@eed3si9n @lrytz @SethTisue @dwijnand @scala-jenkins @xuwei-k @retronym
0