8000 Update instructions / automation for using JITWatch for benchmark analysis by retronym · Pull Request #8000 · scala/scala · GitHub
[go: up one dir, main page]

Skip to content

Update instructions / automation for using JITWatch for benchmark analysis #8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from 8000
May 7, 2019

Conversation

retronym
Copy link
Member
@retronym retronym commented Apr 26, 2019
  • Fix source directories of the benchmarks themselves in the generated
    jitwatch.properties
  • Tell JITWatch where hotspot.log is located
    (see Save UI state when refreshing AdoptOpenJDK/jitwatch#302)
  • Advise use of mvn:exec java rather than launchUI.sh. This should be cross-platform
    and handles compilation and execution in one command.
  • Move some instructions out of README.md and into the output of the jitwatchConfig task.
  • git ignore temp file generated in the working directory when following these instructions.

…alysis

  - Fix source directories of the benchmarks themselves in the generated
    jitwatch.properties
  - Tell JITWatch where hotspot.log is located
    (see AdoptOpenJDK/jitwatch#302)
  - Advise use of `mvn:exec java` rather than `launchUI.sh`. This should be cross-platform
    and handles compilation and execution in one command.
  - Move some instructions out of README.md and into the output of the jitwatchConfig task.
  - git ignore temp file generated in the working directory when following these instructions.
@scala-jenkins scala-jenkins added this to the 2.13.1 milestone Apr 26, 2019
@retronym retronym changed the title Update instructions and automation for using JITWatch for benchmark analysis Update instructions / automation for using JITWatch for benchmark analysis Apr 26, 2019
@retronym retronym requested a review from lrytz April 26, 2019 00:07
@retronym
Copy link
Member Author
retronym commented Apr 26, 2019

To test this out completely, use the issue_302_launch_with_logfile branch of jitwatch

UPDATE JitWatch master now has the changes merged.

@retronym retronym merged commit 45b69fc into scala:2.13.x May 7, 2019
@SethTisue SethTisue modified the milestones: 2.13.1, 2.13.0-RC2 May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0