8000 Add destroyForcibly method to scala.sys.process by MrRexZ · Pull Request #7569 · scala/scala · GitHub
[go: up one dir, main page]

Skip to content

Add destroyForcibly method to scala.sys.process #7569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

MrRexZ
Copy link
Contributor
@MrRexZ MrRexZ commented Dec 24, 2018

For scala/bug#10106

@SethTisue , in that thread, you mentioned about deriving sys.process to be a "module". What's your proposed strategy on for the requirement of the module?

@scala-jenkins scala-jenkins added this to the 2.13.0-RC1 milestone Dec 27, 2018
@SethTisue
Copy link
Member

@SethTisue , in that thread, you mentioned about deriving sys.process to be a "module". What's your proposed strategy on for the requirement of the module?

we had hoped to have time to make that happen in time for 2.13, but now there isn't time.

as for 2.14, I'm still interested, but lately Adriaan (especially) has been making more and more remarks with cautions about how we do these modularizations in order not to impair the beginner/newcomer experience with Scala too much.

anyway, this PR isn't the place to discuss further, since it's a question that deserves a broader audience. some references / places for further discussion: scala/scala-dev#323 , https://contributors.scala-lang.org/t/what-do-we-do-with-scala-sy 8000 s-process/1473/13 , and https://contributors.scala-lang.org/t/modularization-of-scala-2-13-standard-library/635/3

@som-snytt
Copy link
Contributor

I commented on the ticket that it's not obvious that just forwarding various methods is very coherent. Of course, if the code is going to be "spun off" and either abandoned or rewritten, it doesn't matter what happens here.

@SethTisue
Copy link
Member

@MrRexZ let's discuss further on scala/bug#10106. for now, marking this as WIP so it doesn't distract reviewers. (leaving this on the 2.13.0-RC1 milestone for now since if it doesn't make RC1, we won't be able to add it until 2.14.)

@SethTisue SethTisue added the WIP label Jan 28, 2019
@SethTisue SethTisue removed their assignment Jan 31, 2019
@adriaanm
Copy link
Contributor
adriaanm commented Feb 4, 2019

I don't think we'll be able to get this one in, for lack of time (the sys package needs a big overhaul, but that can't happen until 2.14; we'll branch soon, so that renovations can start).

< 8377 !-- no margin wins, so we check it last and use its value if true. -->

@adriaanm adriaanm closed this Feb 4, 2019
@SethTisue SethTisue removed this from the 2.13.0-RC1 milestone Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0