8000 Remove partest orphan files by ashawley · Pull Request #7299 · scala/scala · GitHub
[go: up one dir, main page]
Skip to content

Remove partest orphan files #7299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2018
Merged

Remove partest orphan files #7299

merged 2 commits into from
Oct 2, 2018

Conversation

ashawley
Copy link
Member
@ashawley ashawley commented Oct 2, 2018

There are still extra files after #7255.

These shell commands help to find them.

$ find . -type f -name '*.flags'
         ! -exec sh -c 'test -f ${0%.flags}.scala -o -d ${0%.flags}/' {} \;

$ find . -type f -name '*.check'
         ! -exec sh -c 'test -f ${0%.check}.scala -o -d ${0%.check}/' {} \;

I wonder if they should be used as lint rules for partest suites, or could be added to partest itself.

@ashawley
Remove orphan partest checks
f9a2179 
    find . -type f -name '*.check'
           ! -exec sh -c 'test -f ${0%.check}.scala -o -d ${0%.check}/' {} \;
@ashawley
Remove orphan partest flags
98aee8f 
    find . -type f -name '*.flags'
           ! -exec sh -c 'test -f ${0%.flags}.scala -o -d ${0%.flags}/' {} \;
@scala-jenkins scala-jenkins added this to the 2.13.0-RC1 milestone Oct 2, 2018
ashawley
ashawley commented Oct 2, 2018
View reviewed changes
test/files/instrumented/indy-symbol-literal.check
^
indy-symbol-literal.scala:6: warning: a pure expression does nothing in statement position; multiline expressions might require enclosing parentheses
'warmup
^
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this an accidentally added file in #5310, or was there a test to go along with it that was missed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

History of instrumented shows the test was deleted by #6864

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll keep it deleted, then.

@som-snytt
Copy link
Contributor

#7301 introduces a red flag.

partest --instrumented
[snip]
Extraneous file: /Users/[snip]/scala/test/files/instrumented/indy-symbol-literal.check
Selected 3 tests drawn from 1 named test categories

# starting 3 tests in instrumented

@adriaanm adriaanm merged commit 3a8a338 into scala:2.13.x Oct 2, 2018
@SethTisue
Copy link
Member

thank you Aaron!

@ashawley ashawley deleted the partest-orphans branch October 2, 2018 14:01
66B7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@som-snytt som-snytt som-snytt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.13.0-RC1
Development

Successfully merging this pull request may close these issues.
5 participants
@ashawley @som-snytt @SethTisue @adriaanm @scala-jenkins
0