Bump versions of OSGi testing dependencies for JDK 9 support #6937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've also pushed a config change to make the test pass. |
|
You make it look so easy. Do you even break a sweat? What season is it down under? |
som-snytt
reviewed
Jul 16, 2018
build.sbt
Outdated
| @@ -645,6 +645,7 @@ def osgiTestProject(p: Project, framework: ModuleID) = p | |||
| ) | |||
| }, | |||
| Keys.test in Test := (Keys.test in Test).dependsOn(packageBin in Compile).value, | |||
| Keys.testOnly in Test := (Keys.test in Test).dependsOn(packageBin in Compile).value, | |||
There was a problem hiding this comment.
I don't even understand this, sorry. Why isn't it Keys.testOnly on RHS? This is why for years now I demur from learning sbt internals.
There was a problem hiding this comment.
Pushed a fix. I tested it by ensuring that I could add a ??? to the implementation of reflection and witness the failure from:
> osgiTestEclipse/testOnly
-- tools.test.osgi.BasicTest tools.test.osgi.libonly.BasicLibraryTest
tools.test.osgi.reflection.basic.BasicReflectionTest tools.test.osgi.reflection.toolbox.ReflectionToolBoxTest
> osgiTestEclipse/testOnly
-- tools.test.osgi.BasicTest tools.test.osgi.libonly.BasicLibraryTest
tools.test.osgi.reflection.basic.BasicReflectionTest tools.test.osgi.reflection.toolbox.ReflectionToolBoxTest
> osgiTestEclipse/testOnly tools.test.osgi.reflection.basic.BasicReflectionTest
...
[error] Test tools.test.osgi.reflection.basic.BasicReflectionTest.basicMirrorThroughOsgi failed: scala.NotImplementedError: an implementation is missing, took 0.886 sec
[error] at scala.Predef$.$qmark$qmark$qmark(Predef.scala:341)
This allows them to run under JDK10. The specific problem was resolving the `@jdk.internal.HotSpotInstrinsicCandidate` annotation on `Object.hashCode`, which happens when runtime reflection loads the class symbol for Object. Related docs: https://ops4j1.jira.com/wiki/spaces/PAXEXAM4/pages/54263890/Configuration+Options#ConfigurationOptions-bootDelegationPackages https://ops4j1.jira.com/wiki/spaces/paxrunner/pages/11665431/Boot+delegation+packages
7b6828d to
b536780
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And configure the test OSGi containers to expose
jdk.internalfrom the platform (aka boot) classloader, which we need to resolve@jdk.internal.HotSpotIntrinsicCandidatewhen entering so-annotated methods, e.g.Object.hashCode.