add per-phase profiling to scalac #5848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -338,6 +338,16 @@ trait ScalaSettings extends AbsScalaSettings | |||
|
|
|||
| def YstatisticsEnabled = Ystatistics.value.nonEmpty | |||
|
|
|||
| val YprofileEnabled = BooleanSetting("-Yprofile-enabled", "Enable profiling.") | |||
There was a problem hiding this comment.
This whole pr is super useful. Thank you!
jvican
reviewed
Apr 24, 2017
| @@ -0,0 +1,17 @@ | |||
| package scala.tools.nsc.profile; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Can we simplify and make these docs clearer? There are typos, no capital letter and the actual meat of the docs is hidden under unnecessary words 😄.
|
/rebuild |
87b0f88 to
7677c90
Compare
- Wall Clock Time (ms) - wall clock time - Idle Time (ms) - time blocked - cpu time (ms) - reported cpu time - user time (ms) - reported user time - allocated (mb) - bytes allocated during phase - retainedHeap (mb) - retained heap after phase (enable GC for more accurate counts) - gcTime (ms) - time spent in GC. Adds four flags: -Yprofile-enabled Add per phase profiling information -Yprofile-destination:<file> Where to write profiling information (defaults to console if not set) -Yprofile-run-gc Run GC between phases to help gemerate more more accurate memory usage in profiling -Yprofile-external-tool:<phase> Enable calling of ExternalToolHook.before/after around the target phase
7677c90 to
e929236
Compare
|
Better description (from updated git commit): |
retronym
approved these changes
Jul 3, 2017
There was a problem hiding this comment.
I have some ideas about ways to extend this, but I think its a great starting point and we can include in 2.12.3.
Future work:
- Rather than rendering the profile results to the logger after each compiler run, aggregate them over many runs of the compiler and present summary statistics at the end.
- Try to reuse some of the MXBean based profiler code from JMH rather than DIY (unfortunately this isn't straightforward with the current API of JMH)
|
Great.
I agree those are both good ideas.
… On 4 Jul 2017, at 00:27, Jason Zaugg ***@***.***> wrote:
@retronym approved this pull request.
I have some ideas about ways to extend this, but I think its a great starting point and we can include in 2.12.3.
Future work:
Rather than rendering the profile results to the logger after each compiler run, aggregate them over many runs of the compiler and present summary statistics at the end.
Try to reuse some of the MXBean based profiler code from JMH rather than DIY (unfortunately this isn't straightforward with the current API of JMH)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 11, 2018
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 18, 2018
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 18, 2018
smarter
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 30, 2018
odersky
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.