8000 minor BTypes optimisations by mkeskells · Pull Request #5833 · scala/scala · GitHub
[go: up one dir, main page]
Skip to content

minor BTypes optimisations #5833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2017
Merged

minor BTypes optimisations #5833

merged 1 commit into from
Jun 28, 2017

Conversation

mkeskells
Copy link
Contributor
@mkeskells mkeskells commented Apr 5, 2017 •
edited
Loading

performance result - disapointing - havent looked why

after 10 90% jvm, no GC
                  RunName	Count	           AllWallMS	                   CPU_MS	                Allocated
              00_baseline	36	  2499.87 [+1.05% -0.95%]	  2472.66 [+1.06% -0.96%]	   602.25 [+1.00% -1.00%]
          12_minor_BTypes	34	  2513.46 [+1.03% -0.97%]	  2501.84 [+1.02% -0.97%]	   603.24 [+1.00% -1.00%]

@scala-jenkins scala-jenkins added this to the 2.12.3 milestone Apr 5, 2017
@mkeskells mkeskells mentioned this pull request Apr 6, 2017
Merged
@SethTisue SethTisue added the performance the need for speed. usually compiler performance, sometimes runtime performance. label Jun 27, 2017
retronym
retronym reviewed Jun 28, 2017
View reviewed changes
src/compiler/scala/tools/nsc/backend/jvm/BTypes.scala
/**
* add methods
* @return the added methods. Note the order is undefined
*/
def addIndyLambdaImplMethod(hostClass: InternalName, handle: Seq[asm.Handle]): Seq[asm.Handle] = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out that the order is unspecified. I was sort of worried that this is a (small) problem, and that bytecode generation of lambdaDeserialize will be non-deterministic, but it looks like that part is taken care of by the LinkedHashSet here, and the non-deterministic order in the return value is benign given the way it is used in the inliner.

@retronym retronym merged commit 8bdc2b2 into scala:2.12.x Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retronym retronym retronym approved these changes

Assignees
No one assigned
Labels
performance the need for speed. usually compiler performance, sometimes runtime performance.
Projects
None yet
Milestone
2.12.3
Development

Successfully merging this pull request may close these issues.
4 participants
@mkeskells @retronym @SethTisue @scala-jenkins
0