8000 Compiler performance improvements around Symbols and Types by retronym · Pull Request #5823 · scala/scala · GitHub
[go: up one dir, main page]
Skip to content

Compiler performance improvements around Symbols and Types #5823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 24, 2017
Merged

Compiler performance improvements around Symbols and Types #5823

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5d07122
Avoid BoxesRuntime.equals in Type.unique
retronym Mar 7, 2017
f717ee9
Optimize copyTypeRef to avoid hash consing in some cases
retronym Mar 16, 2017
4a22452
Optimize type comparison around AnnotatedTypes
retronym Mar 16, 2017
9f954e9
Make Symbol.allOverridenSymbols tail recursive
retronym Mar 15, 2017
43f3d85
Opt specializedSym, special case for WildCardType
retronym Mar 17, 2017
fc80f86
Optimize boundSyms by avoiding needless call to typeOfThis
retronym Mar 15, 2017
aa2ccb9
Avoid calling member type in futile matchingSymbolInternal check
retronym Apr 3, 2017
d64765e
Optimize TypeRef#computeHashCode
retronym Mar 10, 2017
d85a087
Optimize TypeRef#equals
retronym Mar 8, 2017
8a53dd0
Add a fast path to TreeGen to speedup synthesis of casts
retronym Apr 3, 2017
b47c989
Avoid List.apply in favor of ::
retronym Mar 9, 2017
f985f1f
Avoid repeating call to Symbol#typeParams in hot code
retronym Mar 28, 2017
67ea707
Minor refactor of TypeRef.computeHashCode
retronym Apr 20, 2017
1517573
Minor refactor in elimSuper pattern match
retronym Apr 20, 2017
9b28b01
Rework changes to specializedSym
retronym Apr 26, 2017
3b9feea
Merge remote-tracking branch 'origin/2.12.x' into faster/symtab
retronym May 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a fast path to TreeGen to speedup synthesis of casts 
Unfortunately, we've had to add a lot more casts into the code
to workaround corner cases in the Fields transform. This commit
avoids an inefficiency in synthesizing these trees, by avoid
a call to as-seen-from.
  • Loading branch information
@retronym
retronym committed Apr 26, 2017
commit 8a53dd0cadfe34538a72fabc89e2ed393e96afae
5 changes: 4 additions & 1 deletion src/reflect/scala/reflect/internal/TreeGen.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,10 @@ abstract class TreeGen {

val tree = Select(pkgQualifier, sym)
if (pkgQualifier.tpe == null) tree
else tree setType (qual.tpe memberType sym)
else tree setType {
if (sym.rawowner == ObjectClass || sym.rawowner == AnyClass) sym.tpeHK.normalize // opt for asInstanceOf
else (qual.tpe memberType sym)
}
}
}

Expand Down
0