10000 Get commit SHA and date with JGit by szeiger · Pull Request #5733 · scala/scala · GitHub
[go: up one dir, main page]

Skip to content

Get commit SHA and date with JGit #5733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2017
Merged

Conversation

szeiger
Copy link
Contributor
@szeiger szeiger commented Feb 23, 2017

In order to get the SHA and date we used to run shell scripts and parse
the output of git commands. On Windows we even ran a batch file that
looked for bash.exe and then ran the shell script in bash.

Using JGit should be more robust than the old Rube Goldberg
implementation. The values produced are the same, except for the time
zone. Previously the timestamp was formatted with the local timezone,
now we use UTC.

@scala-jenkins scala-jenkins added this to the 2.12.2 milestone Feb 23, 2017
@szeiger
Copy link
Contributor Author
szeiger commented Feb 23, 2017

/rebuild

1 similar comment
@adriaanm
Copy link
Contributor

/rebuild

@mkeskells
Copy link
Contributor

I cant verify this on my windows install as I cant access szeiger:wip/use-jgit. Is szeiger:wip private?

@SethTisue
Copy link
Member

@mkeskells the branch name is wip/use-jgit which has a slash character in it — perhaps that's confusing some tool you're using?

@SethTisue
Copy link
Member

@mkeskells the relevant commit is szeiger@acd6967

@mkeskells
Copy link
Contributor

The tool wasnt confused - just me - I was looking for a repo called wip :-(
verified that it works for me, and that it works with a sensible heap size of 2Gb

@SethTisue
Copy link
Member

@szeiger rebase?

In order to get the SHA and date we used to run shell scripts and parse
the output of `git` commands. On Windows we even ran a batch file that
looked for `bash.exe` and then ran the shell script in bash.

Using JGit should be more robust than the old Rube Goldberg
implementation. The values produced are the same, except for the time
zone. Previously the timestamp was formatted with the local timezone,
now we use UTC.
@SethTisue SethTisue merged commit 567aa14 into scala:2.12.x Mar 7, 2017
@szeiger szeiger mentioned this pull request Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0