8000 Fix typos in compiler and reflect by janekdb · Pull Request #5694 · scala/scala · GitHub
[go: up one dir, main page]
Skip to content

Fix typos in compiler and reflect #5694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2017
Merged

Fix typos in compiler and reflect #5694

merged 1 commit into from
Feb 16, 2017

Conversation

janekdb
Copy link
Member
@janekdb janekdb commented Feb 13, 2017

Miscellania:

Miscellania is a small island off the northernmost part of the Fremennik Isles - RunScape Wiki

Miscellanea:

A collection of miscellaneous objects or writings - Merriam-Webster

@janekdb
Fix typos in compiler and reflect
1eb331b 
Miscellania:

  Miscellania is a small island off the northernmost part
  of the Fremennik Isles - RunScape Wiki


Miscellanea:

  A collection of miscellaneous objects or writings - Merriam-Webster
@scala-jenkins scala-jenkins added this to the 2.12.2 milestone Feb 13, 2017
@janekdb
Copy link
Member Author
janekdb commented Feb 16, 2017 •
edited
Loading

Added reviewed label in case the approved status was not being looked for in the PR list.

not-easily-noticed

There should be just one way to indicate the reviewed status.

@janekdb
Copy link
Member Author
janekdb commented Feb 16, 2017

The reviewed label needs adding.

@adriaanm
Copy link
Contributor

there's a review:approved filter that I use to go through the PRs ready for merging. The reviewed label will be phased out.

@SethTisue
Copy link
Member

the ticket on that is scala/scabot#63

@SethTisue SethTisue mentioned this pull request Feb 16, 2017
Closed
@SethTisue SethTisue merged commit 98a7d4c into scala:2.12.x Feb 16, 2017
@SethTisue
Copy link
Member

thanks Janek!

@janekdb janekdb deleted the topic/2.12.x-scaladoc-spelling-corrections-2 branch February 17, 2017 11:14
@SethTisue SethTisue mentioned this pull request Feb 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethTisue SethTisue SethTisue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.12.2
Development

Successfully merging this pull request may close these issues.
4 participants
@janekdb @adriaanm @SethTisue @scala-jenkins
0