8000 Batch files no longer swallow exit codes by xeno-by · Pull Request #54 · scala/scala · GitHub
[go: up one dir, main page]

Skip to content

Batch files no longer swallow exit codes #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally se 8000 nd you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2011
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Batch files no longer swallow exit codes
Usually scripts like scala.bat and scalac.bat correctly propagate
exit codes from underlying Java invocations. However, if you run these
scripts as follows: "cmd /c scala ...", then errorlevel gets swallowed.
This simple patch fixes the aforementioned problem.

Fixes SI-5295, no review.
  • Loading branch information
xeno-by committed Dec 9, 2011
commit d718a7c7f31afee174958f63d23ede87394a7a4a
1 change: 1 addition & 0 deletions src/compiler/scala/tools/ant/templates/tool-windows.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -86,3 +86,4 @@ goto :eof

:end
@@endlocal
exit /b %errorlevel%
2 changes: 1 addition & 1 deletion test/files/jvm/mkLibNatives.bat
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,4 @@ goto end

:end
if "%OS%"=="Windows_NT" @endlocal

exit /b %errorlevel%
1 change: 1 addition & 0 deletions test/partest.bat
Original file line number Diff line number Diff line change
Expand Up @@ -101,3 +101,4 @@ goto end

:end
if "%OS%"=="Windows_NT" @endlocal
exit /b %errorlevel%
0