upgrade asm to 5.1 #5293
Merged
upgrade asm to 5.1 #5293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
734841b to
79abfc7
Compare
| @@ -258,7 +258,8 @@ class CoreBTypes[BTFS <: BTypesFromSymbols[_ <: Global]](val bTypes: BTFS) { | |||
| coreBTypes.jliMethodTypeRef, | |||
| ArrayBType(ObjectRef)), | |||
| coreBTypes.jliCallSiteRef | |||
| ).descriptor) | |||
| ).descriptor, | |||
| /* itf = */ false) | |||
There was a problem hiding this comment.
coreBTypes.jliLambdaMetafactoryRef.isInterface.get ?
|
@lrytz LGTM. I have a similar branch and it works as intended. |
The constructor of scala.tools.asm.Handle now takes an additional boolean parameter to denote whether the owner is an interface.
|
@varming can you take another look? |
|
LGTM. |
10 tasks
smarter
added a commit
to dotty-staging/scala
that referenced
this pull request
Sep 17, 2017
The itf flag of `visitMethodInsn` and `Handle` in ASM needs to be true when the method is defined in an interface. Java 8 ignores this but Java 9 fails at runtime with: java.lang.IncompatibleClassChangeError: Method ... must beInterfaceMethodref constant This commit is inspired by similar changes in scalac, in particular see 7d51b3f by Jason Zaugg (from scala#5251) and e619b03 by Lukas Rytz (from scala#5293). This issue was also discussed in scala#5452 (which does not matter for Dotty since we do not run the backend optimizer).
smarter
added a commit
to lampepfl/scala
that referenced
this pull request
Oct 12, 2017
The itf flag of `visitMethodInsn` and `Handle` in ASM needs to be true when the method is defined in an interface. Java 8 ignores this but Java 9 fails at runtime with: java.lang.IncompatibleClassChangeError: Method ... must beInterfaceMethodref constant This commit is inspired by similar changes in scalac, in particular see 7d51b3f by Jason Zaugg (from scala#5251) and e619b03 by Lukas Rytz (from scala#5293). This issue was also discussed in scala#5452 (which does not matter for Dotty since we do not run the backend optimizer).
allanrenucci
added a commit
to dotty-staging/dotty
that referenced
this pull request
Nov 22, 2017
Original commit from Irytz: e619b033350a3378d650db4c3e5b1bfc83b73d81 Upgrade asm to 5.1 The constructor of scala.tools.asm.Handle now takes an additional boolean parameter to denote whether the owner is an interface.
allanrenucci
added a commit
to scala/scala3
that referenced
this pull request
Nov 22, 2017
smarter
added a commit
to dotty-staging/scala
that referenced
this pull request
Aug 23, 2018
The itf flag of `visitMethodInsn` and `Handle` in ASM needs to be true when the method is defined in an interface. Java 8 ignores this but Java 9 fails at runtime with: java.lang.IncompatibleClassChangeError: Method ... must beInterfaceMethodref constant This commit is inspired by similar changes in scalac, in particular see 7d51b3f by Jason Zaugg (from scala#5251) and e619b03 by Lukas Rytz (from scala#5293). This issue was also discussed in scala#5452 (which does not matter for Dotty since we do not run the backend optimizer).
smarter
added a commit
to dotty-staging/scala
that referenced
this pull request
Aug 23, 2018
The itf flag of `visitMethodInsn` and `Handle` in ASM needs to be true when the method is defined in an interface. Java 8 ignores this but Java 9 fails at runtime with: java.lang.IncompatibleClassChangeError: Method ... must beInterfaceMethodref constant This commit is inspired by similar changes in scalac, in particular see 7d51b3f by Jason Zaugg (from scala#5251) and e619b03 by Lukas Rytz (from scala#5293). This issue was also discussed in scala#5452 (which does not matter for Dotty since we do not run the backend optimizer).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.