Skip module docs in bootstrap script when STARR_REF is used #5019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| # Maybe we should switch to unconditinally doing the second pass (`publishModulesToSonatype`), and | ||
| # find a way to make the second pass overwrite/augment the artifacts from the first pass if they | ||
| # both target `private-repo`. | ||
| set publishArtifact in packageDoc in Compile := false |
This is a second attempt at making this script operate when making a binary incompatible change to the compiler, such as the current effort to change the trait encoding. I have just disabled the docs when STARR_REF is provided, rather than disabling them in the first pass as I tried in c4fc2fd. scala-dev/#89 showed that we can't defer 8000 docs to the second pass, as the second pass isn't always run.
f6bb24c to
ce6ce56
Compare
Seems like the custom "repo_ref" parameter of the https://scala-ci.typesafe.com/job/scala-2.12.x-release-main/315/parameters/ wasn't propagated to the child job https://scala-ci.typesafe.com/job/scala-2.12.x-release-package-unix/191/parameters/ which failed |
|
Looks like this has been incorporated into #5003 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second attempt at making this script operate when
making a binary incompatible change to the compiler, such as
the current effort to change the trait encoding.
I have just disabled the docs when STARR_REF is provided,
rather than disabling them in the first pass as I tried in
c4fc2fd. scala-dev/#89 showed that we can't defer docs to
the second pass, as the second pass isn't always run.