Improve diagnostic error on failed genLoadIdent #4397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error has been haunting us recently, firstly on Greg's machine when compiling the compiler using the new SBT build, and more recently during PR validation in scala#4316. This commit will output an error like: symbol value c#16812 does not exist in Macro.impl, which contains locals value a#16810, value b#16811 I've included symbol IDs in the hope that they will prove useful. It seems that synthetic identifiers generated by the pattern matcher are often seen in the vicinity of this bug.
| case ex: MatchError => | ||
| abort("symbol " + sym + " does not exist in " + ctx.method) | ||
| ctx.method.lookupLocal(sym) match { | ||
| case Some(l) => |
There was a problem hiding this comment.
It sure would be nice if that didn't look like a one. It's too bad I sound so ungrateful when I say that. I bet we could make good use of the Turkish undotted i.
There was a problem hiding this comment.
I agree one letter identifier is not ideal but it's been like that before.
|
/rebuild https://scala-ci.typesafe.com/job/scala-2.11.x-integrate-ide/519/console |
|
LGTM Thanks for submitting this patch! |
gkossakowski
added a commit
that referenced
this pull request
Mar 24, 2015
Improve diagnostic error on failed genLoadIdent
retronym
added a commit
to retronym/scala
that referenced
this pull request
Apr 7, 2015
We have seen an intermittent crasher in the backend for the last month or so. In scala#4397, I added a diagnostic to show the actual locals in scope in the method. This commit further expands the diagnistic to show the method's tree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error has been haunting us recently, firstly on Greg's machine
when compiling the compiler using the new SBT build, and more recently
during PR validation in #4316.
This commit will output an error like:
symbol value c#16812 does not exist in Macro.impl, which contains locals value a#16810, value b#16811
I've included symbol IDs in the hope that they will prove useful.
It seems that synthetic identifiers generated by the pattern matcher
are often seen in the vicinity of this bug.
Review by the haunted: @gkossakowski / @som-snytt