Fixes https://scala-webapps.epfl.ch/jenkins/job/scala-checkin-rangpos/404 #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's a fun one... This makes the second commit in the pull request queue that has a new STARR. They'll both merge cleaning but one will break the other. Word of warning to whoever pulls this or @odersky 's |
|
Fixing rangepos should not require a new starr. The rangepos tests aren't even run on locker, or at least they're not supposed to be. In the absence of new information I plan on merging neither of the starr pull requests. |
szeiger
pushed a commit
to szeiger/scala
that referenced
this pull request
Mar 20, 2018
scala#484) * * Add HashMap test to check scala/collection-strawman#382 * Clean code. * Repeat search of key after evaluating default value. * * Fix code style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.