Extract base scaladoc functionality for the IDE. #1722
Conversation
|
Started jenkins job pr-rangepos at https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/1094/ |
|
jenkins job pr-rangepos: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/1094/ |
|
Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1804/ |
|
jenkins job pr-scala-testsuite-linux-opt: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1804/ |
|
Review by @dragos for presentation compiler changes. |
|
Started jenkins job pr-rangepos at https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/1101/ |
|
jenkins job pr-rangepos: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/1101/ |
|
Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1811/ |
|
jenkins job pr-scala-testsuite-linux-opt: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1811/ |
| @@ -74,6 +74,7 @@ class Global(settings: Settings, _reporter: Reporter, projectName: String = "") | |||
| if (verboseIDE) println("[%s][%s]".format(projectName, msg)) | |||
| override def forInteractive = true | |||
| override def forScaladoc = keepDocComments | |||
There was a problem hiding this comment.
Could we maybe do it the other way around? Make keepDocComments true when forScaladoc is set? I think the entire thing needs a bit of cleanup: we have keepDocComments and forScaladoc in Global and isScaladoc in ScalaSettings. A bit too many ways to achieve the same thing for my tastes...
There was a problem hiding this comment.
Done removed keepDocComments.
|
LGTM, except for two comments I added -- you can address them later, but please don't forget about them. |
|
Actually it would be good to address the |
|
ping @dragos |
|
LGTM on my side too! Thanks Eugene! |
|
PLS REBUILD ALL |
|
Started jenkins job pr-rangepos at https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/1144/ |
|
jenkins job pr-rangepos: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/1144/ |
|
Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1859/ |
|
jenkins job pr-scala-testsuite-linux-opt: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1859/ |
| protected val compilerReporter: CompilerReporter = new InteractiveReporter { | ||
| override def compiler = PresentationCompilerInstance.this.compiler | ||
| } | ||
| protected val projectName = "" |
There was a problem hiding this comment.
where is this overridden?
There was a problem hiding this comment.
On Wed, Dec 12, 2012 at 3:30 AM, Adriaan Moors notifications@github.comwrote:
In
src/compiler/scala/tools/nsc/interactive/tests/core/PresentationCompilerInstance.scala:protected val compilerReporter: CompilerReporter = new InteractiveReporter {
override def compiler = PresentationCompilerInstance.this.compiler
}
- protected val projectName = ""
where is this overridden?
Leftover. Will remove.
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1722/files#r2386688.
|
PLS REBUILD ALL |
|
Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1864/ |
|
jenkins job pr-scala-testsuite-linux-opt: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1864/ |
|
Started jenkins job pr-rangepos at https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/1149/ |
|
jenkins job pr-rangepos: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/1149/ |
|
LRGTM (Looks Really Good to me) |
Extract base scaladoc functionality for the IDE.
Review by @VladUreche.