10000 Removing controversial `either` method from Futures API. by jsuereth · Pull Request #1656 · scala/scala · GitHub
[go: up one dir, main page]
Skip to content

Removing controversial either method from Futures API. #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2012
Merged

Removing controversial either method from Futures API. #1656

merged 1 commit into from
Nov 21, 2012

Conversation

jsuereth
Copy link
Contributor
  • Removes either from Future
  • No tests need to change, since this was an untested method.

Review by @phaller

@jsuereth
Removing controversial either method from Futures API.
ea72460 
* Removes `either` from Future
* No tests need to change, since this was an untested method.
@phaller phaller mentioned this pull request Nov 21, 2012
Merged
@phaller
Copy link
Contributor
phaller commented Nov 21, 2012

LGTM

@phaller
Copy link
Contributor
phaller commented Nov 21, 2012

I also submitted a corresponding update to the futures overview on the doc site (see above)

@scala-jenkins
Copy link

Started jenkins job pr-rangepos at https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/991/

@scala-jenkins
Copy link

jenkins job pr-rangepos: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/991/

@scala-jenkins
Copy link

Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1702/

@scala-jenkins
Copy link

jenkins job pr-scala-testsuite-linux-opt: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1702/

@adriaanm
Copy link
Contributor

I'm fine merging this, but it would be good to know why this is controversial (does it conflict with a method that is added on through implicits?) so that people who might be affected unbeknownst to us at least understand the change.

@heathermiller
Copy link
Member

This has been long-discussed in this thread:
https://groups.google.com/forum/?fromgroups=#!topic/scala-sips/VRlDgX4yFKE

Here, the consensus was to remove it for now. Later, e.g. in 2.10.1, when some consensus is arrived at regarding naming and semantics of this method, we can add it without breaking binary compatibility.

@adriaanm
Copy link
Contributor

Thanks for the link, Heather. Sorry I missed that discussion.

adriaanm added a commit that referenced this pull request Nov 21, 2012
@adriaanm
Merge pull request #1656 from jsuereth/fix/remove-future-either-method
57b91c5 
Removing controversial `either` method from Futures API.
@adriaanm adriaanm merged commit 57b91c5 into scala:2.10.0-wip Nov 21, 2012
@phaller
Copy link
Contributor
phaller commented Nov 21, 2012

Great. Thanks, Heather and Adriaan.

VladUreche pushed a commit to VladUreche/scala.github.com that referenced this pull request Dec 24, 2013
@phaller
Remove paragraph on method 'either'
2143aa0 
Method 'either' of the 'Future' trait will not be part of Scala 2.10.0, therefore
it should not be mentioned in the futures overview article.

The corresponding pull request:
scala/scala#1656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jsuereth @phaller @scala-jenkins @adriaanm @heathermiller
0