Use List.fill instead of range [ci: last-only] #11059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3106171 to
bdce213
Compare
|
hmm, do we have a new unstable test? :-/ it was added recently in #11024 !! 1 - presentation/dollar-completion [output differs]
% diff /home/runner/work/scala/scala/test/files/presentation/dollar-completion.check /home/runner/work/scala/scala/test/files/presentation/dollar-completion-presentation.log
@@ -3,22 +3,14 @@ reload: Completions.scala
askScopeCompletion at Completions.scala(5,2)
================================================================================
[response] askScopeCompletion at (5,2)
-retrieved 16 members
+retrieved 8 members
abstract trait T extends AnyRef
case class C1 extends Product with Serializable
class C2 extends AnyRef
def <init>(x: Int): test.C1
-def canEqual(x$1: Any): Boolean
def copy(x: Int): test.C1
-def productArity: Int
-def productElement(x$1: Int): Any
object C1
-override def equals(x$1: Any): Boolean
-override def hashCode(): Int
-override def productElementName(x$1: Int): String
-override def productIterator: Iterator[Any]
override def productPrefix: String
-override def toString(): String
private[this] val x: Int
================================================================================ |
|
hmm, indeed. I don't remember what my second thoughts were on #10867 to fix something about PC tests. |
lrytz
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to 8c00042
Noticed during scala/scala3#15144 at https://github.com/scala/scala3/blob/main/compiler/src/dotty/tools/dotc/core/classfile/ClassfileParser.scala#L383 where it induced an explanatory comment.