Don't use multi-deprecatedName yet, just nowarn #10631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
commented
Dec 15, 2023
| @@ -10,6 +10,7 @@ import org.junit.runners.JUnit4 | |||
| import scala.tools.testkit.AllocationTest | |||
|
|
|||
| @RunWith(classOf[JUnit4]) | |||
| @annotation.nowarn("msg=Boolean literals should be passed using named argument syntax for parameter selfEqual") | |||
There was a problem hiding this comment.
this isn't needed. It doesn't warn under old and won't warn under new. Are you paying attention?
lrytz
approved these changes
Dec 15, 2023
retronym
approved these changes
Dec 15, 2023
|
whew. I'll take that as a yes. |
93F8
SethTisue
added
the
internal
not resulting in user-visible changes (build changes, tests, internal cleanups)
label
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #10612
In particular, ensure compilation without bootstrap. So @retronym can get some work done.