8000 java.lang.ArrayIndexOutOfBoundsException: 0 by Kobenko · Pull Request #926 · scala/docs.scala-lang · GitHub
[go: up one dir, main page]
Skip to content

java.lang.ArrayIndexOutOfBoundsException: 0 #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2017
Merged

java.lang.ArrayIndexOutOfBoundsException: 0 #926

merged 2 commits into from
Nov 16, 2017

Conversation

Kobenko
Copy link
Contributor
@Kobenko Kobenko commented Nov 12, 2017

No description provided.

@SethTisue
Copy link
Member
SethTisue commented Nov 13, 2017 •
edited
Loading

the intention here was that you pass a single argument on the command line when you run the app. if you don't pass one, you get the ArrayIndexOutOfBoundsException

I tend to agree, though, that setting it up that way it just distracts from the main idea of this part of the tour.

how about just extends StringIterator("Scala")? this avoids the unnecessary extra val, plus it's "Scala" not "SCALA"

@Kobenko
Copy link
Contributor Author
Kobenko commented Nov 14, 2017

Yes, passing a string value to an argument would be a good option

@Kobenko
Copy link
Contributor Author
Kobenko commented Nov 16, 2017 •
edited 8000
Loading

@SethTisue how often do you merge the branches? I have several more suggestions for improving the tour.

@SethTisue SethTisue merged commit 84cf61d into scala:master Nov 16, 2017
@SethTisue
Copy link
Member

thank you for this!

merging PRs is done on no particular schedule by Heather, myself, and others. I usually don't merge things until they've been sitting for a few days, to allow time for community review and feedback.

there is certainly plenty of room for improvement left on the tour — looking forward to further suggestions and pull requests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SethTisue SethTisue SethTisue approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kobenko @SethTisue
0