-
Notifications
You must be signed in to change notification settings - Fork 1k
Reworked case class tutorial #547 #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
94fad22
Reworked case class tutorial #547
jatcwang 2dfa9c4
Put tut:fail for code block that should fail to compile
jatcwang 6230bc9
Remove mentions of generated code + reworded last paragraph
jatcwang 87582d4
remove mentions of generated code
jatcwang 4c647e5
reword last bullet point
jatcwang bc8cf17
lower case "Pattern Matching" and "Case Classes" since they're not pr…
jatcwang aee907b
comments about using 'vars' in case class fields.
jatcwang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this code block is designed to fail then
tut
should betut:fail
. This will allow tut to give an error if the code block compiles. It is a little weird.https://github.com/tpolecat/tut
Also check the Travis logs if they fail. They will show you where to look to fix the problem. :-)
https://travis-ci.org/scala/scala.github.com/builds/166207587
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'll fix this up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jarrodwb I have fixed this a TravisCI run is passing.