8000 Replace flags with endonyms to link to localization by eed3si9n · Pull Request #449 · scala/docs.scala-lang · GitHub
[go: up one dir, main page]
Skip to content

Replace flags with endonyms to link to localization #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2015
Merged

Replace flags with endonyms to link to localization #449

merged 1 commit into from
Aug 24, 2015

Conversation

eed3si9n
Copy link
Member

Fixes #448.

This change replaces series of a img elements with ul.langbar li a. The localized name for each language is kept in a common YAML file called _data/languages.yml. This file could be used to keep more localized text down the line.

I tried to make the language bar blend into the existing design of the pages. Here are some samplings.

Cheatsheet

scalacheat_-_scala_documentation

Guides and Overviews

guides_and_overviews_-_scala_documentation

Overview pages

string-interpolation

@heathermiller
Copy link
Member

LGTM :)

heathermiller added a commit that referenced this pull request Aug 24, 2015
@heathermiller
Merge pull request #449 from eed3si9n/topic/endonym
a4b18c8 
Replace flags with endonyms to link to localization
@heathermiller heathermiller merged commit a4b18c8 into scala:master Aug 24, 2015
@eed3si9n eed3si9n deleted the topic/endonym branch August 24, 2015 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eed3si9n @heathermiller
0