8000 Some suggestions in the Scala 3 book (2) by julienrf · Pull Request #2073 · scala/docs.scala-lang · GitHub
[go: up one dir, main page]

Skip to content

Some suggestions in the Scala 3 book (2) #2073

New 8000 issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

julienrf
Copy link
Contributor
@julienrf julienrf commented Jun 7, 2021

I’ve reviewed the following chapters:

  • a first look at types
  • control structures
  • domain modeling

Here are some simple suggestions, or typos fixes.

Maybe @alvinj you are interested in reviewing?

@julienrf julienrf requested a review from b-studios June 7, 2021 16:36
@alvinj
Copy link
Contributor
alvinj commented Jun 8, 2021

Maybe @alvinj you are interested in reviewing?

Hi @julienrf. Yes, I’ll be glad to review these, though it might be Saturday before I can get to them.

@alvinj
Copy link
Contributor
alvinj commented Jun 12, 2021

though it might be Saturday before I can get to them.

Sorry, please make that Sunday, June 13th. (I’ll review them then.)

Copy link
Contributor
@alvinj alvinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these changes look great — thanks!

I’ve reviewed the following chapters:
- a first look at types
- control structures
- domain modeling

Here are some simple suggestions, or typos fixes.
@julienrf julienrf force-pushed the scala3-book-suggestions-part2 branch from dc69e23 to 5bc689d Compare June 14, 2021 09:35
@julienrf julienrf merged commit b6d27d4 into scala:main Jun 14, 2021
@julienrf julienrf deleted the scala3-book-suggestions-part2 branch June 14, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0