-
Notifications
You must be signed in to change notification settings - Fork 1k
Add Thai translation #1110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Thai translation #1110
Conversation
@SethTisue @heathermiller |
@SethTisue said: "ultimately we'll end up merging it regardless, but we do normally prefer to have two sets of native-speaker eyes on translations if we can get them" |
I don't have other to work with me for this translation, it's no chance to merge. |
let's wait a while, there's a lot of users on GitHub. Hopefully somebody steps up to validate the PR. |
This translation seems to be a little bit rough for me (as a native speaker). In my opinion, some specific words should not be translated into Thai (since those words are not exists in Thai dictionary). So, It might be easier for the reader if you can keep those words in English. Also, the structure of each sentence should be adapt into Thai sentence's structure. This translation seems to be reversed. And some typos like อ้างอิ่ง -> อ้างอิง, ตัวแปล -> ตัวแปร |
@kajornsakp Thank you for reviewed, I will fixed as your mentions. What we should do on translation between transliteration and keep it in English. |
@iphayao Could you rebase this on top of master and let me know when this is good to be merged? 😄 |
@jvican I did rebased from master, please go ahead to merge for Thai translation initial. Thank you ^_^ |
thanks all! |
Adding Thai translation, start with cheatsheets