8000 Add Thai translation by iphayao · Pull Request #1110 · scala/docs.scala-lang · GitHub
[go: up one dir, main page]

Skip to content

Add Thai translation #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 15, 2018
Merged

Add Thai translation #1110

merged 6 commits into from
Aug 15, 2018

Conversation

iphayao
Copy link
Contributor
@iphayao iphayao commented Jul 26, 2018

Adding Thai translation, start with cheatsheets

@iphayao
Copy link
Contributor Author
iphayao commented Jul 28, 2018

@SethTisue @heathermiller
What is criteria to merge pull request?

@xingyif
Copy link
Contributor
xingyif commented Jul 31, 2018

@SethTisue said:

"ultimately we'll end up merging it regardless, but we do normally prefer to have two sets of native-speaker eyes on translations if we can get them"

@iphayao
Copy link
Contributor Author
iphayao commented Jul 31, 2018

I don't have other to work with me for this translation, it's no chance to merge.

@iphayao iphayao closed this Jul 31, 2018
@iphayao iphayao reopened this Jul 31, 2018
@Philippus
Copy link
Member

let's wait a while, there's a lot of users on GitHub. Hopefully somebody steps up to validate the PR.

@kajornsakp
Copy link

This translation seems to be a little bit rough for me (as a native speaker). In my opinion, some specific words should not be translated into Thai (since those words are not exists in Thai dictionary). So, It might be easier for the reader if you can keep those words in English.

Also, the structure of each sentence should be adapt into Thai sentence's structure. This translation seems to be reversed.

And some typos like อ้างอิ่ง -> อ้างอิง, ตัวแปล -> ตัวแปร

@iphayao
Copy link
Contributor Author
iphayao commented Jul 31, 2018

@kajornsakp Thank you for reviewed, I will fixed as your mentions.

What we should do on translation between transliteration and keep it in English.

@jvican
Copy link
Member
jvican commented Aug 15, 2018

@iphayao Could you rebase this on top of master and let me know when this is good to be merged? 😄

@iphayao
Copy link
Contributor Author
iphayao commented Aug 15, 2018

@jvican I did rebased from master, please go ahead to merge for Thai translation initial.

Thank you ^_^

@SethTisue SethTisue merged commit 753d524 into scala:master Aug 15, 2018
@SethTisue
Copy link
Member

thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0