8000 [1.7.x] lm-coursier-shaded 2.0.12 by eed3si9n · Pull Request #7060 · sbt/sbt · GitHub
[go: up one dir, main page]
Skip to content

[1.7.x] lm-coursier-shaded 2.0.12 #7060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2022
Merged

[1.7.x] lm-coursier-shaded 2.0.12 #7060

merged 1 commit into from
Oct 31, 2022

Conversation

eed3si9n
Copy link
Member
@eed3si9n eed3si9n commented Oct 31, 2022 •
edited
Loading

@eed3si9n eed3si9n merged commit 3d53ae1 into sbt:1.7.x Oct 31, 2022
@eed3si9n eed3si9n deleted the bport/coursier branch October 31, 2022 00:46
@unkarjedy unkarjedy mentioned this pull request Oct 31, 2022
Closed
@bjaglin bjaglin mentioned this pull request Nov 2, 2022
Closed
@julienrf
Copy link
Contributor
julienrf commented Nov 6, 2022

I wonder if this change introduced a binary incompatibility. I had to apply the following change in sbt-version-policy to upgrade from 1.7.2 to 1.7.3: scalacenter/sbt-version-policy@db2f37c

(otherwise, I got the following error: https://github.com/scalacenter/sbt-version-policy/actions/runs/3402173263/jobs/5657742540#step:5:1665

@eed3si9n
Copy link
Member Author
eed3si9n commented Nov 6, 2022

lm-coursier-shaded should shade Shapeless if Coursier is using it, so I am not sure how what resulted to policy change related to Shapeless. Could it also be something to do with the implementation change in Coursier itself since it got fast forwarded by a year?

@julienrf
Copy link
Contributor
julienrf commented Nov 7, 2022 •
edited
Loading

The error wasn’t related to Shapeless, but to the API of Coursier:

Error:  /tmp/sbt_57e6ea27/build.sbt:47: error: value only is not a member of object lmcoursier.definitions.ModuleMatchers
Error:          ModuleMatchers.only(Module(Organization("com.chuusai"), ModuleName("shapeless_2.12"), Map())) -> Reconciliation.Strict
Error:                         ^
Error:  sbt.compiler.EvalException: Type error in expression

There used to be a method lmcoursier.definitions.ModuleMatchers.only with a compatible signature, but it is not here anymore.

@eed3si9n
Copy link
Member Author
eed3si9n commented Nov 7, 2022

Ah. That's because we switched code generation to Scalafix for Scala 3 purpose. We now need:

import lmcoursier.syntax._

I had to do that in #7060 as well.

@julienrf
Copy link
Contributor
julienrf commented Nov 7, 2022

Yes, but my point is that it seems that lm-coursier-shaded 2.0.12 is not binary compatible with version 2.0.10. This is surprising given that it’s a patch version bump.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eed3si9n @julienrf
0