This repository was archived by the owner on Jul 24, 2023. It is now read-only.
Allow access to python bytearrays as []byte #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 8000 | // Return the contents of bytearray as []bytes, size length | |
| func PyByteArray_AsBytesN(self *PyObject, length int) []byte { | ||
| c_str := C.PyByteArray_AsString(topy(self)) | ||
| return C.GoBytes(unsafe.Pointer(c_str),C.int(length)) |
There was a problem hiding this comment.
perhaps check that the passed length is within the allowed range?
ie: call _gopy_PyByteArray_GET_SIZE and compare (+panic with out of range)
|
LGTM modulo the minor comments above. thanks! |
|
Ok, I've changed the docstring and the length type to uint64 + check the given length argument vs. the bytearray length (panic if it is out of range). |
|
you should keep |
|
Ah, ok. length is back to int (+ check if >= 0) |
sbinet
added a commit
that referenced
this pull request
Aug 7, 2015
Allow access to python bytearrays as []byte
|
thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the existing functions I could not find a way to handle python bytearrays that contain zeros - PyByteArray_AsString always cuts the string off at the first zero byte (I guess C.GoString is responsible). Hence I've added the two functions to create []bytes from bytearrays. I'm not sure if that creates a memory leak though.