8000 Adding python model version capabilities and python null value scoring by jameskochubasas · Pull Request #43 · sassoftware/python-sasctl · GitHub
[go: up one dir, main page]

Skip to content

Adding python model version capabilities and python null value scoring #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 28, 2019
Merged

Adding python model version capabilities and python null value scoring #43

merged 4 commits into from
Oct 28, 2019

Conversation

jameskochubasas
Copy link
Contributor

If you want to create a new version of an existing python model, the anything that is not "new" will create the next version of the model.

Also, fixed the python wrapper to handle null/None values for numeric values so the scoring works properly.

@codecov
Copy link
codecov bot commented Oct 28, 2019

Codecov Report

Merging #43 into master will increase coverage by 0.23%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   82.55%   82.78%   +0.23%     
==========================================
  Files          40       40              
  Lines        2379     2376       -3     
==========================================
+ Hits         1964     1967       +3     
+ Misses        415      409       -6
Impacted Files Coverage Δ
src/sasctl/utils/pymas/core.py 92.79% <100%> (+0.13%) ⬆️
src/sasctl/tasks.py 81.73% <28.57%> (+3.73%) ⬆️
src/sasctl/_services/model_repository.py 82.67% <28.57%> (-3.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77baa33...ca1e24a. Read the comment docs.

@jlwalke2 jlwalke2 merged commit 91179e2 into sassoftware:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0