8000 Fixing the MM performance capabilities for all models by jameskochubasas · Pull Request #42 · sassoftware/python-sasctl · GitHub
[go: up one dir, main page]
Skip to content

Fixing the MM performance capabilities for all models #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 23, 2019
Merged

Fixing the MM performance capabilities for all models #42

merged 8 commits into from
Oct 23, 2019

Conversation

jameskochubasas
Copy link
Contributor

No description provided.

@codecov
Copy link
codecov bot commented Oct 22, 2019 •
edited
Loading

Codecov Report

Merging #42 into master will decrease coverage by 1.19%.
The diff coverage is 45.07%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #42     +/-   ##
=========================================
- Coverage   83.75%   82.55%   -1.2%     
=========================================
  Files          40       40             
  Lines        2320     2379     +59     
=========================================
+ Hits         1943     1964     +21     
- Misses        377      415     +38
Impacted Files Coverage Δ
src/sasctl/utils/pymas/ds2.py 70.89% <100%> (ø) ⬆️
src/sasctl/utils/astore.py 68.11% <5.71%> (-20.57%) ⬇️
src/sasctl/_services/model_management.py 76% <60%> (-1.47%) ⬇️
src/sasctl/tasks.py 78% <86.66%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e1bd7...5ca8491. Read the comment docs.

@jameskochubasas
Copy link
Contributor Author

Added a fix to hopefully fix the 3.5 json.loads issue. I don't have a older test environment to test.

@jlwalke2
fixed case
40793c4 
initial caps on sklearn model since this is displayed in MM
@jlwalke2
fix string compare
381001a 
case-insensitive comparison
@jlwalke2
Copy link
Collaborator

What was the reasoning for changing the project/model function to lower case? Example: 'Prediction' changed to 'prediction'. Doesn't really matter internally, but did you check if it's still capitalized correctly when displayed in MM?

@jameskochubasas
Copy link
Contributor Author

MM apis where checking for lower case so the MM performance page did not see these are classifications/prediction models.

@jlwalke2 jlwalke2 merged commit b3c34e6 into sassoftware:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameskochubasas @jlwalke2
0