This repository was archived by the owner on May 15, 2023. It is now read-only.
Set id on all OutboundMessage with id field #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkme
added a commit
to sass-contrib/sass-embedded-host-ruby
that referenced
this pull request
Mar 26, 2022
message type without id
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Mar 31, 2022
This adds changelog entries for sass/dart-sass-embedded#80 and sass/embedded-host-node#118.
jathak
pushed a commit
to sass/dart-sass
that referenced
this pull request
Apr 1, 2022
This adds changelog entries for sass/dart-sass-embedded#80 and sass/embedded-host-node#118.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With multiple fileImportRequest that missing id (defaults to zero) send to host, the host will respond multiple times with id 0, causing
Response ID 0 doesn't match any outstanding requests.This PR add id to all known OutboundMessage types that needs an id field.
Note that this is not going to reproducible on the node host due to that the node host would start a new compiler process each time. But this causes parallel compile requests with FileImporter on the ruby host to crash.