8000 Merge pull request #2406 from wbern/allow-node-lts-14 · sammarks/rushstack@d775738 · GitHub
[go: up one dir, main page]
Skip to content

Commit d775738

Browse files
octogonzoctogonz
authored
Merge pull request microsoft#2406 from wbern/allow-node-lts-14
[rush] Allow node LTS version 14 in the monorepo
2 parents d6f1ff3 + 9ebac9a commit d775738

File tree

5 files changed

+27
-8
lines changed

5 files changed

+27
-8
lines changed

‎apps/rush-lib/assets/rush-init/rush.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,11 @@
120120
*
121121
* Specify a SemVer range to ensure developers use a Node.js version that is appropriate
122122
* for your repo.
123+
*
124+
* LTS schedule: https://nodejs.org/en/about/releases/
125+
* LTS versions: https://nodejs.org/en/download/releases/
123126
*/
124-
"nodeSupportedVersionRange": ">=12.13.0 <13.0.0",
127+
"nodeSupportedVersionRange": ">=12.13.0 <13.0.0 || >=14.15.0 <15.0.0",
125128

126129
/**
127130
* Odd-numbered major versions of Node.js are experimental. Even-numbered releases

‎apps/rush-lib/src/logic/NodeJsCompatibility.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,11 @@ import { RushConfiguration } from '../api/RushConfiguration';
99
/**
1010
* This constant is the major version of the next LTS node Node.js release. This constant should be updated when
1111
* a new LTS version is added to Rush's support matrix.
12+
*
13+
* LTS schedule: https://nodejs.org/en/about/releases/
14+
* LTS versions: https://nodejs.org/en/download/releases/
1215
*/
13-
const UPCOMING_NODE_LTS_VERSION: number = 14;
16+
const UPCOMING_NODE_LTS_VERSION: number = 16;
1417
const nodeVersion: string = process.versions.node;
1518
const nodeMajorVersion: number = semver.major(nodeVersion);
1619

@@ -40,7 +43,7 @@ export class NodeJsCompatibility {
4043
}
4144

4245
public static warnAboutVersionTooOld(): boolean {
43-
if (semver.satisfies(nodeVersion, '< 8.9.0')) {
46+
if (semver.satisfies(nodeVersion, '< 10.13.0')) {
4447
// We are on an ancient version of Node.js that is known not to work with Rush
4548
console.error(
4649
colors.red(

‎common/changes/@microsoft/rush/allow-node-lts-14_2021-01-12-20-14.json

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
{
2+
"changes": [
3+
{
4+
"packageName": "@microsoft/rush",
5+
"comment": "Update Node.js version checks to support the new LTS release",
6+
"type": "none"
7+
}
8+
],
9+
"packageName": "@microsoft/rush",
10+
"email": "4673363+octogonz@users.noreply.github.com"
11+
}

‎common/config/azure-pipelines/ci.yaml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,9 @@ jobs:
1111
NodeVersion: 10
1212
'NodeJs 12':
1313
NodeVersion: 12
14-
# Currently broken by "[DEP0097] DeprecationWarning: Using a domain property in MakeCallback is deprecated."
15-
# The "domain" package is deprecated, but these dependencies are still importing it: "asap", "pn", "async-done"
16-
# 'NodeJs 14':
17-
# NodeVersion: 14
14+
'NodeJs 14':
15+
NodeVersion: 14
16+
1817
steps:
1918
- checkout: self
2019
- template: templates/build.yaml

‎rush.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,11 @@
120120
*
121121
* Specify a SemVer range to ensure developers use a Node.js version that is appropriate
122122
* for your repo.
123+
*
124+
* LTS schedule: https://nodejs.org/en/about/releases/
125+
* LTS versions: https://nodejs.org/en/download/releases/
123126
*/
124-
"nodeSupportedVersionRange": ">=10.13.0 <11.0.0 || >=12.13.0 <13.0.0",
127+
"nodeSupportedVersionRange": ">=10.13.0 <11.0.0 || >=12.13.0 <13.0.0 || >=14.15.0 <15.0.0",
125128

126129
/**
127130
* Odd-numbered major versions of Node.js are experimental. Even-numbered releases

0 commit comments

Comments
 (0)
0