8000 [rush] Allow node LTS version 14 in the monorepo by wbern · Pull Request #2406 · microsoft/rushstack · GitHub
[go: up one dir, main page]
Skip to content

[rush] Allow node LTS version 14 in the monorepo #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 12, 2021
Merged

[rush] Allow node LTS version 14 in the monorepo #2406

merged 6 commits into from
Jan 12, 2021

Conversation

wbern
Copy link
Contributor
@wbern wbern commented Dec 22, 2020

Summary

I noticed that Node 14 LTS wasn't allowed in the rushstack monorepo, and I assume we support LTS in the monorepo.

Details

I just added || 14 because that'll work for any minor/patch under version 14.

How it was tested

Ran rush update and rush build after, seems to work! 👍

@iclanton
Copy link
Member

We actually removed support (#1979) for Node 14 (see note here) because a deprecation warning was causing build issues.

Looks like fixing that fell through the cracks. If we add Node 14 back to the supported version list, we should also turn CI builds with Node 14 back on.

Are you seeing these warnings that we were seeing before? If you aren't, which version of Node are you using?

octogonz
octogonz reviewed Dec 29, 2020
View reviewed changes
@octogonz octogonz requested a review from apostolisms as a code owner January 12, 2021 19:50
@wbern wbern requested a review from patmill as a code owner January 12, 2021 20:14
@octogonz
Copy link
Collaborator

We actually removed support (#1979) for Node 14 (see note here) because a deprecation warning was causing build issues.

Looks like fixing that fell through the cracks. If we add Node 14 back to the supported version list, we should also turn CI builds with Node 14 back on.

Done. @iclanton it seems to be building fine now. IIRC that warning involved a pre-LTS version of Node 14, and maybe the deprecated NPM package got upgraded eventually.

@octogonz octogonz merged commit d775738 into microsoft:master Jan 12, 2021
@octogonz octogonz mentioned this pull request Feb 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octogonz octogonz octogonz approved these changes

@D4N14L D4N14L Awaiting requested review from D4N14L

@halfnibble halfnibble Awaiting requested review from halfnibble

@iclanton iclanton Awaiting requested review from iclanton

@sachinjoseph sachinjoseph Awaiting requested review from sachinjoseph

@apostolisms apostolisms Awaiting requested review from apostolisms

@patmill patmill Awaiting requested review from patmill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wbern @iclanton @octogonz
0