8000 pkgrepo: account for 'name' attr being part of the state by mattp- · Pull Request #68107 · saltstack/salt · GitHub
[go: up one dir, main page]
Skip to content

pkgrepo: account for 'name' attr being part of the state #68107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 3006.x
Choose a base branch
from
Open

pkgrepo: account for 'name' attr being part of the state #68107

wants to merge 1 commit into from

Conversation

mattp-
Copy link
Contributor
@mattp- mattp- commented Jun 24, 2025

What issues does this PR fix or reference?

fixes #21369. 'name' of repo wasn't being tracked for changes as it was getting special handling due to being outside of the states kwargs. I'm not 100% sure that name is safe across all repo types this state manages, but it fixes the root issue referenced, and I'm pretty sure it's ok.

Previous Behavior

'name' changes were not accounted for in highstates.

New Behavior

'name' changes now are accounted for.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@mattp- mattp- requested a review from a team as a code owner June 24, 2025 17:18
twangboy
twangboy reviewed Jun 27, 2025
View reviewed changes
Copy link
Contributor
@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get a changelog for this, please?

@twangboy twangboy added the test:full Run the full test suite label Jun 27, 2025
@twangboy twangboy added this to the Sulfur v3006.14 milestone Jun 27, 2025
@mattp-
Copy link
Contributor Author
mattp- commented Jun 27, 2025

@twangboy sure, done & rebased

@twangboy
Copy link
Contributor

I'm not seeing the changelog

@mattp-
pkgrepo: account for 'name' attr being part of the state
dda7a36 
fixes saltstack#21369. I'm not 100% sure that name is safe across all repo types
this state manages, but it fixes the root issue referenced, and I'm
pretty sure it's ok.
@mattp-
Copy link
Contributor Author
mattp- commented Jun 27, 2025

sorry, there now. not sure what happened there with precommit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twangboy twangboy twangboy left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
test:full Run the full test suite
Projects
None yet
Milestone
Sulfur v3006.14
Development

Successfully merging this pull request may close these issues.
2 participants
@mattp- @twangboy
0