8000 [master] override test kwarg to be a bool for state.apply and state.highstate by ITJamie · Pull Request #65876 · saltstack/salt · GitHub
[go: up one dir, main page]
Skip to content

[master] override test kwarg to be a bool for state.apply and state.highstate #65876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2024
Merged

[master] override test kwarg to be a bool for state.apply and state.highstate #65876

merged 1 commit into from
Jan 19, 2024

Conversation

ITJamie
Copy link
Contributor
@ITJamie ITJamie commented Jan 16, 2024 •
edited
Loading

What does this PR do?

when calling state.apply or state.highstate commands from slack_bolt_engine the "test" arg should be supplied as a boolean instead of a string

What issues does this PR fix or reference?

Fixes: #65868

Previous Behavior

test arg was passed as a string

New Behavior

test arg is converted to a boolean

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@ITJamie ITJamie requested a review from a team as a code owner January 16, 2024 16:09
@ITJamie ITJamie requested review from whytewolf and removed request for a team January 16, 2024 16:09
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title override test kwarg to be a bool for state.apply and state.highstate [master] override test kwarg to be a bool for state.apply and state.highstate Jan 16, 2024
@ITJamie ITJamie temporarily deployed to ci January 16, 2024 16:26 — with GitHub Actions Inactive
@dwoz dwoz merged commit de002b6 into saltstack:master Jan 19, 2024
@ITJamie ITJamie mentioned this pull request Jun 24, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwoz dwoz dwoz approved these changes

@whytewolf whytewolf Awaiting requested review from whytewolf whytewolf was automatically assigned from saltstack/team-core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] slack_bolt_engine - state.apply/state.highstate - passing test=false does not work (on minion set to test=true by default)
2 participants
@ITJamie @dwoz
0