Remove reference cycle when query returns error. #18552
Merged
+398
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add tests for refference cycles in error handling * Patch execution context * Clear errors * Patch ExecutionResult * Adjust tests
przlada
approved these changes
Nov 24, 2025
patrys
approved these changes
Nov 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it allows memory to be freed immediately without needing a deep garbage collection cycle when the API returns an error.
We don't create a bugfix in the original repository because GraphQL-core-legacy is not supported.
Port #18549
Impact
Docs
Pull Request Checklist
ADDED_IN_X,PREVIEW_FEATURE, etc.)