E52F feat: add systemd provider by Tarow · Pull Request #611 · sablierapp/sablier · GitHub
[go: up one dir, main page]
Skip to content

feat: add systemd provider #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Tarow wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: add systemd provider #611

Tarow wants to merge 3 commits into from

Conversation

@Tarow
Copy link
@Tarow Tarow commented May 25, 2025

Addresses #148

As of now it's still WIP as tests will have to be added etc.

@Tarow Tarow mentioned this pull request May 25, 2025
Open
@codecov
Copy link
codecov bot commented May 25, 2025

Codecov Report

Attention: Patch coverage is 0.99502% with 199 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/provider/systemd/unit_list.go 0.00% 65 Missing ⚠️
pkg/provider/systemd/events.go 0.00% 35 Missing ⚠️
pkg/provider/systemd/unit_inspect.go 0.00% 31 Missing ⚠️
pkg/provider/systemd/unit_start.go 0.00% 22 Missing ⚠️
pkg/provider/systemd/unit_stop.go 0.00% 22 Missing ⚠️
cmd/sablier/provider.go 0.00% 12 Missing ⚠️
pkg/provider/systemd/systemd.go 0.00% 12 Missing ⚠️
Files with missing lines Coverage Δ
cmd/sablier/cmd.go 84.03% <100.00%> (+0.27%) ⬆️
pkg/config/provider.go 0.00% <ø> (ø)
cmd/sablier/provider.go 0.00% <0.00%> (ø)
pkg/provider/systemd/systemd.go 0.00% <0.00%> (ø)
pkg/provider/systemd/unit_start.go 0.00% <0.00%> (ø)
pkg/provider/systemd/unit_stop.go 0.00% <0.00%> (ø)
pkg/provider/systemd/unit_inspect.go 0.00% <0.00%> (ø)
pkg/provider/systemd/events.go 0.00% <0.00%> (ø)
pkg/provider/systemd/unit_list.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
sonarqubecloud bot commented May 25, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
9.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@acouvreur
Copy link
Member
acouvreur commented May 26, 2025

Hey @Tarow !

Thanks for this nice contribution!

Do you think we could add tests using testcontainers ? That should work inside a clean ubuntu image right ? We could write some helper functions to manipulate the systemd files.

I will take a closer look to the files when I have time, I'm quite busy at the moment.

@Tarow
Copy link
Author
Tarow commented May 26, 2025

Getting systemd to work in Docker containers can be a bit tricky. AFAIK it only works in rootful containers and i'm not sure if/how good it will work with Testcontainers.
I can explore it a bit when i find time, but in case it isn't possible, writing a mock for the systemd interface might be the only option.

@sonarqubecloud
Copy link
sonarqubecloud bot commented Jul 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
9.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acouvreur acouvreur Awaiting requested review from acouvreur acouvreur will be requested when the pull request is marked ready for review acouvreur is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tarow @acouvreur
0