fix(kubernetes): support public labels #452
Conversation
There's an issue with a nil pointer, I have to fix that |
| return nil, err | ||
| } | ||
| selector := labels.NewSelector() | ||
| selector = selector.Add(*requirement, *requirementDeprecated) |
There was a problem hiding this comment.
If you merge the 2 selector type here, the deployments will need to have both legacy and new labels because the selector would result in sablier.enable=true,sablierapp.dev/enable=true.
I don't know how to handle this, either deprecate old selectors or add a flag to toggle legacy/new (or make it customizable?)
There was a problem hiding this comment.
After a bit more tweaking I got it to work, I added a bunch of Trace logging to help me find the root cause and it was mainly due to old discovery.LabelGroup usage.
I rebased main onto my branch (449-xxx) so I cannot open a PR on yours but you can see my diff here: main...BapRx:sablier:449-kubernetes-labels-not-public
There was a problem hiding this comment.
Awesome, I will check it out.
closes #449