8000 Update releasing runbook by sdb9696 · Pull Request #2 · rytilahti/python-kasa · GitHub
[go: up one dir, main page]
Skip to content

Update releasing runbook #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2024
Merged

Update releasing runbook #2

merged 2 commits into from
Jun 5, 2024

Conversation

sdb9696
Copy link
@sdb9696 sdb9696 commented Jun 5, 2024

No description provided.

@rytilahti rytilahti force-pushed the janitor/update_release_instructions branch from fa60ed9 to 9044411 Compare June 5, 2024 13:09
@sdb9696 sdb9696 force-pushed the janitor/update_releasing branch from 152df9c to b627350 Compare June 5, 2024 13:11
rytilahti
rytilahti requested changes Jun 5, 2024
View reviewed changes
Copy link
Owner
@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Some comments, mainly about avoiding to add unnecessary information and keeping it short as this is just for us maintainers :-)

@sdb9696 sdb9696 requested a review from rytilahti June 5, 2024 15:06
rytilahti
rytilahti reviewed Jun 5, 2024
View reviewed changes
rytilahti
rytilahti approved these changes Jun 5, 2024
View reviewed changes
Copy link
Owner
@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after exporting the variables.

@rytilahti rytilahti merged commit 9970787 into rytilahti:janitor/update_release_instructions Jun 5, 2024
@sdb9696 sdb9696 deleted the janitor/update_releasing branch June 5, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytilahti rytilahti rytilahti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdb9696 @rytilahti
0