8000 refactor(state): drop untilDestroyed operator by michaelbe812 · Pull Request #1838 · rx-angular/rx-angular · GitHub
[go: up one dir, main page]
Skip to content

refactor(state): drop untilDestroyed operator #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 28, 2025
Merged

refactor(state): drop untilDestroyed operator #1838

merged 3 commits into from
Jan 28, 2025

Conversation

michaelbe812
Copy link
Contributor

Drops untilDestroyed operator in favor of takeUntilDestroyed

@github-actions github-actions bot added the { } State @rx-angular/state related label Jan 8, 2025
@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Jan 8, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit eeee73b.

Command Status Duration Result
nx affected -t lint build test component-test e... ✅ Succeeded 1m 37s View ↗
nx build docs ✅ Succeeded 23s View ↗
nx-cloud record -- npx nx format:check ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-08 09:26:24 UTC

edbzn
edbzn reviewed Jan 8, 2025
View reviewed changes
hoebbelsB
hoebbelsB reviewed Jan 8, 2025
View reviewed changes
@michaelbe812
Copy link
Contributor Author

@hoebbelsB @edbzn
is there anything which speaks against merging this PR? :)

@edbzn
Copy link
Member
edbzn commented Jan 28, 2025

Not from me :) looks good

@michaelbe812
Copy link
Contributor 9E85 Author

Not from me :) looks good

Just asking bc. I can not merge it :)

@hoebbelsB hoebbelsB merged commit d3defff into rx-angular:main Jan 28, 2025
7 checks passed
@michaelbe812 michaelbe812 deleted the f/rx-effects-refactoring branch January 29, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoebbelsB hoebbelsB hoebbelsB approved these changes

@edbzn edbzn edbzn approved these changes

Assignees
No one assigned
Labels
{ } State @rx-angular/state related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelbe812 @edbzn @hoebbelsB
0